Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guessit parser not using scene exceptions #7699

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix guessit parser not using scene exceptions #7699

merged 2 commits into from
Feb 5, 2020

Conversation

medariox
Copy link
Contributor

@medariox medariox commented Feb 5, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox medariox added this to the 0.3.12 milestone Feb 5, 2020
@p0psicles
Copy link
Contributor

Did this fix a particular issue? Exceptions returns the same as aliases right? I agree though that's it's better to use aliases

@medariox
Copy link
Contributor Author

medariox commented Feb 5, 2020

No, sadly it doesn't return anything at all (empty set), unless aliases is explicitly set and I don't think that's done anywhere... https://github.com/pymedusa/Medusa/blob/master/medusa/tv/series.py#L600

@medariox medariox merged commit 535869a into develop Feb 5, 2020
@medariox medariox deleted the fix/guessit-use-it branch February 5, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.3.12
Development

Successfully merging this pull request may close these issues.
2 participants
@medariox @p0psicles